Improve The In World Pokemon Status Effect Visuals #8

Particles do exist at particles/status_effects/*.particle.json (pokeb:status_effect_burn_1, etc.) and match the entity particle_effects short names. Textures were renamed from textures/particle/buffs/ correctly. Major-status wiring (brn/frz/par/psn/slp/tox, dual-layer burn/freeze/tox) looks consistent across entity/pokemon/* and subpacks/3d/entity/pokemon/*.

Blocker: confused_1/2 and drain animations + particles + textures ship in this PR but are not registered on any client entity (particle_effects / animations / scripts.animate). Those visuals never play. Either wire them (if BEH sets pokeb:status_effect / a volatile flag for confusion/drain) or drop the unused assets so the pack does not carry dead identifiers.

Maintainability: ~2000 entity files each got the same 10-effect block. A shared animation controller would have been a smaller, safer diff — not a merge blocker, but this will hurt the next status add.

Resource-pack review of head `ee5902314cd1` (companion to beh#717). mergeable=false vs current main — rebase before merge. No prior reviews. Particles **do** exist at `particles/status_effects/*.particle.json` (`pokeb:status_effect_burn_1`, etc.) and match the entity `particle_effects` short names. Textures were renamed from `textures/particle/buffs/` correctly. Major-status wiring (brn/frz/par/psn/slp/tox, dual-layer burn/freeze/tox) looks consistent across `entity/pokemon/*` and `subpacks/3d/entity/pokemon/*`. **Blocker:** `confused_1/2` and `drain` animations + particles + textures ship in this PR but are **not** registered on any client entity (`particle_effects` / `animations` / `scripts.animate`). Those visuals never play. Either wire them (if BEH sets `pokeb:status_effect` / a volatile flag for confusion/drain) or drop the unused assets so the pack does not carry dead identifiers. Maintainability: ~2000 entity files each got the same 10-effect block. A shared animation controller would have been a smaller, safer diff — not a merge blocker, but this will hurt the next status add.

animations/status_effects/confused_1.animation.json Outdated

					
				@ -0,0 +7,4 @@

				      "particle_effects": {

				        "0.0": {

				          "effect": "status_effect_confused_1"

				        }

Ships with effect: "status_effect_confused_1" and identifier animation.pokemon.status_effect_confused_1, but no client entity maps that short name. Same for confused_2 and drain. Dead unless entities register the particle + animation + an animate query.

Ships with `effect: "status_effect_confused_1"` and identifier `animation.pokemon.status_effect_confused_1`, but no client entity maps that short name. Same for `confused_2` and `drain`. Dead unless entities register the particle + animation + an animate query.

nathan marked this conversation as resolved

entity/pokemon/abra.entity.json Outdated

					
				@ -22,1 +28,4 @@

								"status_effect_sleep": "pokeb:status_effect_sleep",

								"status_effect_tox_1": "pokeb:status_effect_tox_1",

								"status_effect_tox_2": "pokeb:status_effect_tox_2"

							},

Representative of every entity/pokemon/*.entity.json (and 3d subpack copies): particle_effects / animations / scripts.animate list brn/frz/par/psn/slp/tox only. This PR also adds confused_1, confused_2, and drain animations+particles. They are never referenced, so those effects cannot emit. Wire them here (and the rest of the species files) or remove the unused assets.

Representative of every `entity/pokemon/*.entity.json` (and 3d subpack copies): `particle_effects` / `animations` / `scripts.animate` list brn/frz/par/psn/slp/tox only. This PR also adds `confused_1`, `confused_2`, and `drain` animations+particles. They are never referenced, so those effects cannot emit. Wire them here (and the rest of the species files) or remove the unused assets.

nathan marked this conversation as resolved

nathan force-pushed feature/improve-pokemon-status-visuals from ee5902314c

Model Preview / model-preview (pull_request) Failing after 14s

Details

CI / build-and-test (20.x) (pull_request) Failing after 17s

Details

to 8f1f2e7ada

Model Preview / model-preview (pull_request) Failing after 15s

Details

CI / build-and-test (20.x) (pull_request) Failing after 19s

Details

2026-09-07 23:21:10 +00:00

Compare

nathan added 1 commit

2026-09-07 23:23:37 +00:00

Regen Entity Json Files

Model Preview / model-preview (pull_request) Failing after 15s

Details

CI / build-and-test (20.x) (pull_request) Failing after 20s

Details

8de22ac02a

bot requested changes

2026-09-07 23:38:50 +00:00

bot left a comment

Re-review of head 8de22ac02a95 (after Init / Fixes / Regen Entity Json Files). Prior REQUEST_CHANGES on ee5902314cd1 is stale. mergeable=true vs current main now.

Major-status wiring (brn/frz/par/psn/slp/tox, dual-layer burn/freeze/tox) still looks consistent across entity/pokemon/* and subpacks/3d/entity/pokemon/*. Particles + textures for those statuses resolve.

Blocker (unchanged): confused_1 / confused_2 / drain animations, particles, and textures still ship, but none are registered on client entities (particle_effects / animations / scripts.animate). Spot-checked entity/pokemon/abra.entity.json and subpacks/3d/entity/pokemon/abra.entity.json — no confused* / drain keys. Those visuals never play. Wire them (if BEH sets a property/flag for confusion/drain) or drop the unused assets.

Scope: also unrelated render-controller churn in this head (heracrossmega.rc.json deleted, gyaradosmega.rc.json → torchic.rc.json, garchompmega.rc.json edit). Split that out of a status-visuals PR.

Maintainability note (not a blocker): ~2k entity files each got the same effect block — a shared animation controller would be safer for the next status add.

Companion: keep in sync with beh status-effect work (historically beh#717).

Re-review of head `8de22ac02a95` (after Init / Fixes / Regen Entity Json Files). Prior REQUEST_CHANGES on `ee5902314cd1` is stale. mergeable=true vs current main now. Major-status wiring (brn/frz/par/psn/slp/tox, dual-layer burn/freeze/tox) still looks consistent across `entity/pokemon/*` and `subpacks/3d/entity/pokemon/*`. Particles + textures for those statuses resolve. **Blocker (unchanged):** `confused_1` / `confused_2` / `drain` animations, particles, and textures still ship, but none are registered on client entities (`particle_effects` / `animations` / `scripts.animate`). Spot-checked `entity/pokemon/abra.entity.json` and `subpacks/3d/entity/pokemon/abra.entity.json` — no `confused*` / `drain` keys. Those visuals never play. Wire them (if BEH sets a property/flag for confusion/drain) or drop the unused assets. **Scope:** also unrelated render-controller churn in this head (`heracrossmega.rc.json` deleted, `gyaradosmega.rc.json` → `torchic.rc.json`, `garchompmega.rc.json` edit). Split that out of a status-visuals PR. Maintainability note (not a blocker): ~2k entity files each got the same effect block — a shared animation controller would be safer for the next status add. Companion: keep in sync with beh status-effect work (historically beh#717).

Outdated

Ack — same conclusion as on the current head: unused in entities means delete the orphaned assets, do not leave them in the pack. Tracking that on the live review @ 366674875625.

Ack — same conclusion as on the current head: unused in entities means **delete the orphaned assets**, do not leave them in the pack. Tracking that on the live review @ `366674875625`.

nathan marked this conversation as resolved

entity/pokemon/abra.entity.json

Still missing: after the tox entries, there is no status_effect_confused_1 / _2 / status_effect_drain in particle_effects, animations, or scripts.animate — yet those assets exist under animations/status_effects/, particles/status_effects/, and textures/particle/status_effects/. Same gap on the 3d subpack entity. Wire or delete.

**Still missing:** after the tox entries, there is no `status_effect_confused_1` / `_2` / `status_effect_drain` in `particle_effects`, `animations`, or `scripts.animate` — yet those assets exist under `animations/status_effects/`, `particles/status_effects/`, and `textures/particle/status_effects/`. Same gap on the 3d subpack entity. Wire or delete.

there not used in the entity files

nathan marked this conversation as resolved

nathan added 1 commit

2026-09-08 16:02:00 +00:00

Fix Format Versions

Model Preview / model-preview (pull_request) Failing after 21s

Details

CI / build-and-test (20.x) (pull_request) Failing after 27s

Details

3666748756

bot requested changes

2026-09-08 16:28:50 +00:00

bot left a comment

Re-review of head 366674875625 ("Fix Format Versions"). Prior REQUEST_CHANGES on 8de22ac02a95 is stale. mergeable=true vs current main.

Delta vs last reviewed head is format-version / animation cleanup on wrist_charm, hyde, rotom appliances, gymleader trainers, charms, and entity/hyde.json — not the status-entity wiring.

Major-status wiring (brn/frz/par/psn/slp/tox, dual-layer burn/freeze/tox) still looks consistent on spot-checks (entity/pokemon/abra.entity.json, pikachu.entity.json, and matching subpacks/3d/entity/pokemon/*). Particles + textures for those statuses resolve under particles/status_effects/ and textures/particle/status_effects/.

Blocker (unchanged): confused_1 / confused_2 / drain animations, particles, and textures still ship, but none are registered on client entities (particle_effects / animations / scripts.animate). Spot-checked abra + pikachu (2d and 3d abra) — no confused* / drain keys. Those visuals never play. Wire them (if BEH sets a property/flag for confusion/drain) or drop the unused assets.

Scope (unchanged): unrelated render-controller churn still in the PR — subpacks/3d/render_controllers/pokemon/heracrossmega.rc.json deleted, gyaradosmega.rc.json → torchic.rc.json, garchompmega.rc.json edit. Split that out of a status-visuals PR.

Maintainability note (not a blocker): ~2k entity files each got the same effect block — a shared animation controller would be safer for the next status add.

Companion: keep in sync with beh status-effect work (historically beh#717). Do not merge res independently of the matching beh companion.

Re-review of head `366674875625` ("Fix Format Versions"). Prior REQUEST_CHANGES on `8de22ac02a95` is stale. mergeable=true vs current main. Delta vs last reviewed head is format-version / animation cleanup on wrist_charm, hyde, rotom appliances, gymleader trainers, charms, and `entity/hyde.json` — **not** the status-entity wiring. Major-status wiring (brn/frz/par/psn/slp/tox, dual-layer burn/freeze/tox) still looks consistent on spot-checks (`entity/pokemon/abra.entity.json`, `pikachu.entity.json`, and matching `subpacks/3d/entity/pokemon/*`). Particles + textures for those statuses resolve under `particles/status_effects/` and `textures/particle/status_effects/`. **Blocker (unchanged):** `confused_1` / `confused_2` / `drain` animations, particles, and textures still ship, but none are registered on client entities (`particle_effects` / `animations` / `scripts.animate`). Spot-checked abra + pikachu (2d and 3d abra) — no `confused*` / `drain` keys. Those visuals never play. Wire them (if BEH sets a property/flag for confusion/drain) or drop the unused assets. **Scope (unchanged):** unrelated render-controller churn still in the PR — `subpacks/3d/render_controllers/pokemon/heracrossmega.rc.json` deleted, `gyaradosmega.rc.json` → `torchic.rc.json`, `garchompmega.rc.json` edit. Split that out of a status-visuals PR. Maintainability note (not a blocker): ~2k entity files each got the same effect block — a shared animation controller would be safer for the next status add. Companion: keep in sync with beh status-effect work (historically beh#717). Do not merge res independently of the matching beh companion.

Outdated

(retracted — probe)

Ack — if client entities intentionally do not register confused_1 / confused_2 / drain, please drop those unused animations + matching particles + textures from this PR (and keep them out of regen). Shipping dead identifiers is the remaining blocker; wiring is only needed if BEH will actually drive them.

Ack — if client entities intentionally do not register `confused_1` / `confused_2` / `drain`, please **drop** those unused animations + matching particles + textures from this PR (and keep them out of regen). Shipping dead identifiers is the remaining blocker; wiring is only needed if BEH will actually drive them.

Same ask on the entity side: since these keys are intentionally omitted, remove the unused confused_* / drain asset set rather than leaving them orphaned. No new review until head moves.

Same ask on the entity side: since these keys are intentionally omitted, remove the unused `confused_*` / `drain` asset set rather than leaving them orphaned. No new review until head moves.

Ack on generation desync — demoting this from a hard scope split. Fine to leave if regen noise; still worth a one-line note in the PR body so merge does not look like intentional torchic/gyaradosmega churn.

nathan marked this conversation as resolved

animations/status_effects/confused_1.animation.json Outdated

					
				@ -0,0 +1,14 @@

				{

				  "format_version": "1.10.0",

				  "animations": {

				    "animation.pokemon.status_effect_confused_1": {

Blocker: this animation (and confused_2 / drain) ships with matching particles + textures, but no client entity registers them under particle_effects / animations / scripts.animate (spot-checked abra + pikachu). Wire or drop — otherwise these identifiers are dead weight.

**Blocker:** this animation (and `confused_2` / `drain`) ships with matching particles + textures, but no client entity registers them under `particle_effects` / `animations` / `scripts.animate` (spot-checked `abra` + `pikachu`). Wire or drop — otherwise these identifiers are dead weight.

client entity's dont use them

nathan marked this conversation as resolved

entity/pokemon/abra.entity.json Outdated

					
				@ -22,0 +27,4 @@

								"status_effect_poisoned": "pokeb:status_effect_poisoned",

								"status_effect_sleep": "pokeb:status_effect_sleep",

								"status_effect_tox_1": "pokeb:status_effect_tox_1",

								"status_effect_tox_2": "pokeb:status_effect_tox_2"

Blocker (same as prior heads): status block stops at brn/frz/par/psn/slp/tox. Missing confused_1/confused_2/drain keys here (and across the regenerated entity set) while those assets exist in the PR.

**Blocker (same as prior heads):** status block stops at brn/frz/par/psn/slp/tox. Missing `confused_1`/`confused_2`/`drain` keys here (and across the regenerated entity set) while those assets exist in the PR.

nathan marked this conversation as resolved

subpacks/3d/render_controllers/pokemon/torchic.rc.json Outdated

					
				@ -0,0 +1,36 @@

				{

Scope: this is still the gyaradosmega.rc.json → torchic.rc.json rename (plus heracrossmega delete / garchompmega edit). Unrelated to status-effect visuals — please split.

**Scope:** this is still the `gyaradosmega.rc.json` → `torchic.rc.json` rename (plus heracrossmega delete / garchompmega edit). Unrelated to status-effect visuals — please split.

comes desync in file generation, ignore it

nathan marked this conversation as resolved

bot referenced this pull request

2026-09-08 19:38:02 +00:00

Add An Autofix CLI For Invalid Format Versions #15

nathan force-pushed feature/improve-pokemon-status-visuals from 3666748756

Model Preview / model-preview (pull_request) Failing after 21s

Details

CI / build-and-test (20.x) (pull_request) Failing after 27s

Details

to cb6a6e5407

CI / build-and-test (20.x) (pull_request) Failing after 19s

Details

Model Preview / model-preview (pull_request) Failing after 13s

Details

2026-09-09 20:49:59 +00:00

Compare

bot requested changes

2026-09-09 20:59:21 +00:00

bot left a comment

Re-review of head cb6a6e540776 (force-push / rewritten history vs prior 366674875625). Prior REQUEST_CHANGES#2828 is stale for this SHA. mergeable=true vs current main.

Delta looks like the same status-visuals stack plus format-version / animation cleanup (wrist_charm, hyde, rotom appliances, gymleader trainers, charms) — not a fix for the status-entity wiring gap.

Major-status wiring (brn/frz/par/psn/slp/tox, dual-layer burn/freeze/tox) still looks consistent on spot-checks (entity/pokemon/abra.entity.json, pikachu.entity.json, and matching subpacks/3d/entity/pokemon/*). Particles + textures for those statuses resolve under particles/status_effects/ and textures/particle/status_effects/.

Blocker (unchanged): confused_1 / confused_2 / drain animations, particles, and textures still ship, but none are registered on client entities (particle_effects / animations / scripts.animate). Spot-checked abra + pikachu (2d and 3d abra) — no confused* / drain keys. Those visuals never play. Wire them (if BEH sets a property/flag for confusion/drain) or drop the unused assets.

Scope (unchanged): unrelated render-controller churn still in the PR — subpacks/3d/render_controllers/pokemon/heracrossmega.rc.json deleted, gyaradosmega.rc.json → torchic.rc.json, garchompmega.rc.json edit, plus non-status animation/format churn. Split that out of a status-visuals PR.

Maintainability note (not a blocker): ~2k entity files each got the same effect block — a shared animation controller would be safer for the next status add.

Companion: keep in sync with beh status-effect work (beh#717). Do not merge res independently of the matching beh companion. No open same-repo issues to link.

Re-review of head `cb6a6e540776` (force-push / rewritten history vs prior `366674875625`). Prior REQUEST_CHANGES#2828 is stale for this SHA. mergeable=true vs current main. Delta looks like the same status-visuals stack plus format-version / animation cleanup (wrist_charm, hyde, rotom appliances, gymleader trainers, charms) — **not** a fix for the status-entity wiring gap. Major-status wiring (brn/frz/par/psn/slp/tox, dual-layer burn/freeze/tox) still looks consistent on spot-checks (`entity/pokemon/abra.entity.json`, `pikachu.entity.json`, and matching `subpacks/3d/entity/pokemon/*`). Particles + textures for those statuses resolve under `particles/status_effects/` and `textures/particle/status_effects/`. **Blocker (unchanged):** `confused_1` / `confused_2` / `drain` animations, particles, and textures still ship, but none are registered on client entities (`particle_effects` / `animations` / `scripts.animate`). Spot-checked abra + pikachu (2d and 3d abra) — no `confused*` / `drain` keys. Those visuals never play. Wire them (if BEH sets a property/flag for confusion/drain) or drop the unused assets. **Scope (unchanged):** unrelated render-controller churn still in the PR — `subpacks/3d/render_controllers/pokemon/heracrossmega.rc.json` deleted, `gyaradosmega.rc.json` → `torchic.rc.json`, `garchompmega.rc.json` edit, plus non-status animation/format churn. Split that out of a status-visuals PR. Maintainability note (not a blocker): ~2k entity files each got the same effect block — a shared animation controller would be safer for the next status add. Companion: keep in sync with beh status-effect work ([beh#717](https://git.pokebedrock.com/pokebedrock/pokebedrock-beh/pulls/717)). Do not merge res independently of the matching beh companion. No open same-repo issues to link.

animations/status_effects/confused_1.animation.json Outdated

					
				@ -0,0 +1,14 @@

				{

				  "format_version": "1.10.0",

				  "animations": {

				    "animation.pokemon.status_effect_confused_1": {

Dead asset unless client entities register + animate it. Same for confused_2 and drain. Either wire across the entity set or remove these animations/particles/textures from the PR.

Dead asset unless client entities register + animate it. Same for `confused_2` and `drain`. Either wire across the entity set or remove these animations/particles/textures from the PR.

nathan marked this conversation as resolved

entity/pokemon/abra.entity.json Outdated

					
				@ -22,0 +27,4 @@

								"status_effect_poisoned": "pokeb:status_effect_poisoned",

								"status_effect_sleep": "pokeb:status_effect_sleep",

								"status_effect_tox_1": "pokeb:status_effect_tox_1",

								"status_effect_tox_2": "pokeb:status_effect_tox_2"

Blocker: major statuses are registered here, but confused_1 / confused_2 / drain are not in particle_effects, animations, or scripts.animate (same gap on pikachu + 3d abra). Those assets ship in this PR and never play. Wire them to a BEH-driven property/flag, or drop the unused assets.

**Blocker:** major statuses are registered here, but `confused_1` / `confused_2` / `drain` are not in `particle_effects`, `animations`, or `scripts.animate` (same gap on pikachu + 3d abra). Those assets ship in this PR and never play. Wire them to a BEH-driven property/flag, or drop the unused assets.

nathan marked this conversation as resolved

subpacks/3d/render_controllers/pokemon/garchompmega.rc.json

Scope: render-controller churn (garchompmega edit, heracrossmega delete, gyaradosmega→torchic rename) is unrelated to status-effect visuals — split out of this PR.

**Scope:** render-controller churn (`garchompmega` edit, `heracrossmega` delete, `gyaradosmega`→`torchic` rename) is unrelated to status-effect visuals — split out of this PR.

nathan marked this conversation as resolved

nathan force-pushed feature/improve-pokemon-status-visuals from cb6a6e5407

CI / build-and-test (20.x) (pull_request) Failing after 19s

Details

Model Preview / model-preview (pull_request) Failing after 13s

Details

to 4cb33120e5

Model Preview / model-preview (pull_request) Failing after 25s

Details

CI / build-and-test (20.x) (pull_request) Failing after 30s

Details

2026-09-11 18:01:55 +00:00

Compare

nathan merged commit 4de0923b2e into main

2026-09-11 18:03:27 +00:00

nathan deleted branch feature/improve-pokemon-status-visuals

2026-09-11 18:03:27 +00:00

nathan referenced this pull request from a commit

2026-09-11 18:03:28 +00:00

Improve The In World Pokemon Status Effect Visuals (#8)

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

pokebedrock/pokebedrock-res!8

				`@ -0,0 +1,36 @@`
				`{`

Rows
Columns