feature/quests-rework-menu #25
No reviewers
Labels
No labels
No milestone
No project
No assignees
2 participants
smell-of-curry
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
pokebedrock/pokebedrock-res!25
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/quests-rework-menu"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Review @
7146e2df(res companion to beh/datafeature/quests-rework-menu)No blockers. The wiring checks out against the beh branch head
993ad7d6:$quest_chest_flagstrings inui/chest_server_form.jsonmatch the ids in behsrc/pokebedrock/config/chestGui.ts, and all 7 menu textures they point at are added here.langKeys.ts, or thetDynamiccategory/group/line/requirement ids inquestMenus.ts/forms/quests.ts), and every category, group and line id inquestMenus.tshas a matching key. Nothing referenced is missing.textures/ui/quests/*.pngicons are used viaQUEST_ICONin behquestMenus.ts.%1%%inpokedexPercentmatches the existing escape style (forms.serverPokedex.label.done).Should-fix (copy):
forms.quests.requirement.megaEvolve=Mega Evolve %1x timescounts twice; it renders as "Mega Evolve 5x times". UseMega Evolve %1xto match the rest of the requirement lines. Same string in all 7 locale files.Nits:
2.
forms.quests.group.alternativeForms=Alternative Formis singular, while the group holds three forms and the id is plural.Alternative Formsreads better as a heading.3. The six non-English locale files get the English text verbatim (69 lines each). If the translation flow fills these later, fine; if not, consider leaving them out so the missing keys stay visible to translators instead of looking done.
4. The rewards/notifications keys (
button.exitRewards,button.questRewards,button.rewards,label.completionReward,button.notifications,notifications.*) are appended afterstatus.lockedinstead of next to theirbutton.*/label.*siblings. Purely ordering.5. The 7 new grid blocks in
chest_server_form.jsondiffer only in size, texture, flag, close-button offset and grid offset. Optional: a shared template with$variables would cut ~250 duplicated lines, though the existing screens in this file are also written out longhand, so this is not required.CI (
build-and-test,model-preview) was still pending at review time. Merge-ready needs green CI plus a maintainer approval, and should land together with the beh/data companions.@ -11361,0 +11366,4 @@forms.quests.category.growth=Growthforms.quests.category.progression=Progressionforms.quests.category.special=Specialforms.quests.group.alternativeForms=Alternative FormNit: singular
Alternative Formfor a group of three forms (id isalternativeForms).Alternative Forms?@ -11361,0 +11401,4 @@forms.quests.line.stayAtHomePets=Stay at Home Pets!forms.quests.status.comingSoon=§cComing Soonforms.quests.status.locked=§cLOCKEDforms.quests.button.exitRewards=Exit Rewards MenuNit: this rewards/notifications block sits after
status.lockedrather than with the otherbutton.*/label.*keys. Ordering only.@ -11379,0 +11432,4 @@forms.quests.requirement.collectEgg=Collect %1x daycare eggsforms.quests.requirement.holdMegaRing=Hold a Mega Ring in your off-handforms.quests.requirement.holdPokeDollars=Have %1 PokéDollarsforms.quests.requirement.megaEvolve=Mega Evolve %1x times%1x timesdouble-counts ("Mega Evolve 5x times"). SuggestMega Evolve %1x, and the same in the other 6 locale files.@ -365,2 +365,4 @@}},{"quests_main_grid_image": {Optional: this and the next 6 blocks differ only in size/texture/flag/close offset/grid offset. A shared template with
$vars would remove the duplication. Not blocking, since the rest of this file is written longhand too.Re-review @
40d30d74(delta since7146e2df: lang files only, same edit in all 7 locales)No blockers. This commit addresses the earlier review 3208:
forms.quests.requirement.megaEvolveis nowMega Evolve %1x, matching the other requirement lines.forms.quests.group.alternativeFormsis nowAlternative Forms.button.*/label.*siblings, andstatus.*moved afternotifications.*. No keys were added or removed, so the beh wiring checked last time still holds.Still open from 3208 (nits, not blocking): the six non-English locales carry the English text verbatim, and the 7 near-identical grid blocks in
ui/chest_server_form.jsoncould share a template.CI (
build-and-test,model-preview) was pending at review time. Merge-ready still needs green CI, a maintainer approval, and landing together with the data #20 / beh quest-menu companions.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.