feat; add title system UI, glyph sheet #10
No reviewers
Labels
No labels
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
pokebedrock/pokebedrock-res!10
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/title-update"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I dont think the form handling is correct
way better
@ -11648,3 +11648,10 @@ forms.emojiShop.success.purchased=§aYou unlocked the §e%s§a for §e%s§a Tokeforms.emojiShop.success.claimed=§aYou claimed the §e%s§a!forms.emojiShop.error.insufficientTokens=§cYou need §e%s§c Tokens but only have §e%s§c.forms.emojiShop.error.alreadyOwned=§cYou already own the §e%s§c.## Titleswhy did this one not get a space like the others?
Resource-pack review of head
0d8963072a8d(companion to beh#722). mergeable=false vs current main — rebase before merge.UI wiring is the right pattern:
$flag_titles=§t§i§t§l, subtracted from the default long-form visible/enabled bindings,titles@titles.main_panelgated the same way._ui_defs.json+titles_gui.png+glyph_E3.pngare present. Human reviews are stale (ffce79eREQUEST_CHANGES,9d2fabbAPPROVED).Blocker:
events.beforeChat.formatis changed in every locale to strip the[rank]brackets. That is global chat, not title-UI scope. If titles are meant to replace the rank prefix, say so and keep it; otherwise revert the format key so this PR stays title-system only.Title strings (
forms.titles.*,commands.tags.*) are English in all 7 locales. Fine as a first pass, but not localized.@ -3974,3 +3974,3 @@events.beforeChat.error.tooManyEmojis=§cA maximum of %s emojis can be sent in a single message.events.beforeChat.error.zalgo=§cYour message contains zalgo and cannot be sent!events.beforeChat.format=§r§l§8[§r%s§r§l§8]§r§7 %s:§r %sevents.beforeChat.format=§r%s§r§7 %s:§r %sThis is the live chat format for every message, not a titles-form string. It drops
§l§8[§r%s§l§8]so ranks no longer render in brackets. Unrelated to "add title system UI, glyph sheet" unless beh#722 is deliberately replacing the prefix with a glyph title — if so, call that out; if not, revert this key.@ -0,0 +40,4 @@"anchor_from": "top_left","anchor_to": "top_left","grid_dimensions": [2, 14],"collection_name": "form_buttons",Hard cap of 28 slots (
[2, 14]).#form_button_lengthcan grow past that and the extra titles never get a cell. Either document the 28-title max with BEH or bind grid rows from the collection length so new titles do not clip.Re-review head
dfb0c8f25188(was0d8963072a8d). Companion beh#722.This push: drops unused
commands.tags.error.unknownTitleacross all 7 langs. Correct — beh review already marked that key unused. Note behlangKeys.tsstill lists it untilgenerate:langKeysruns against this RP.Cleared:
events.beforeChat.formatbracket strip. Intentional with behbeforeChat.ts— title glyph + ranks are built into the first%s; the lang string must not wrap it again. Prior inline on that line is obsolete context.Still blocking:
mergeable=falsevs currentmain. Rebase before merge. Do not merge res ahead of beh#722.Still open (no new inline):
titles_server_form.jsongrid_dimensions: [2, 14]hard-caps 28 cells. Catalog is 25 titles today, so it fits, but anything past 28 silently clips. Prefer binding rows from collection length or document the cap with BEH.Nit: title strings remain English in non-EN locales.
Human reviews still stale (
ffce79eREQUEST_CHANGES,9d2fabbAPPROVE).CI
build-and-testfailed on headdfb0c8f25188(run 142).Likely cause:
npm run syncLangFiles -- --check. Locale files are not en_US-ordered/byte-sync (e.g.es_ESkey order aroundevents.beforeChat.*; other langs trailing blank-line drift). Fix: runnpm run syncLangFileson the branch and push. Do not merge until green + rebase onto currentmain(stillmergeable=false).dfb0c8f251c539085c39Re-review head
c539085c3980(wasdfb0c8f25188). Companion beh#722 still open — do not merge res alone.This push: adds
commands.tags.error.alreadyGranted/success.revoked/error.notGrantedacross all 7 langs (matches commit message).mergeable=truevs currentmain— prior unmergeable hold is cleared.Still blocking — CI:
ci.ymlrun 144 failure on this head (model-preview #145 success is not the gate). Same class of failure asdfb0c8f: locale files are notsyncLangFiles --checkclean.Still blocking — lang hygiene: non-EN files still append a second
## Emoji Updateblock + mojibake (┬º/ broken UTF-8) after PHUD.pt_BRstill has twoevents.beforeChat.formatlines; first is the old bracketed form. Repo keeps first value on duplicates, so Portuguese chat format will not pick up the title-aware string. Fix:npm run syncLangFileson the branch (drop tails, restore§, en_US order) and push.Still open:
titles_server_form.jsongrid_dimensions: [2, 14]hard-caps 28 cells.Nit: title strings remain English in non-EN locales; tip also dropped a few unrelated crate/tera keys into
en_US— keep the PR title-scoped.Human reviews still stale (
ffce79eREQUEST_CHANGES,9d2fabbAPPROVE). Open res issues: 0 (no Fixes links).@ -11657,3 +11657,36 @@ commands.spawnrate.success=Nastavení výskytu aktualizováno.## PHUDphud.playerPing.label=Aktuální ping:## Emoji UpdateTrailing re-append after PHUD: second
## Emoji Updateblock + mojibake (┬º/ mangled Czech). Same pattern in de/es/ru/zh/pt. This is what keepssyncLangFiles --check/ CI red. Runnpm run syncLangFilesand push — do not hand-append keys.@ -3974,6 +3974,26 @@ events.beforeChat.error.tooFast=§cVocê está enviando mensagens muito rapidameevents.beforeChat.error.tooManyEmojis=§cA maximum of %s emojis can be sent in a single message.events.beforeChat.error.zalgo=§cSua mensagem contém zalgo e não pode ser enviada!events.beforeChat.format=§r§l§8[§r%s§r§l§8]§r§7 %s:§r %sFirst
events.beforeChat.formatis still the old bracketed string; a second corrected copy appears ~20 lines later. This repo keeps the first value on duplicate keys, so pt_BR will not use the title-aware format. Delete the old line (and the mid-file mojibake restart block) — prefernpm run syncLangFiles.@ -0,0 +38,4 @@"size": ["100%", 182],"offset": [2, 0],"anchor_from": "top_left","anchor_to": "top_left",Still open:
grid_dimensions: [2, 14]hard-caps 28 cells. Catalog fits today (~25), but growth past 28 silently clips. Prefer binding rows from collection length or document the cap with beh#722.Re-review head
225f5df337ab(wasc539085c3980). Companion beh#722 still open — do not merge res alone.This push: adds
commands.tags.warning.stillOwnedacross all 7 langs. Correct pairing for the still-owned revoke path; leave it.Still blocking — CI:
ci.ymlrun 146 failure on this head (CI / build-and-test). Model-preview #147 success is not the gate. SamesyncLangFiles --checkclass asc539085c.Still blocking — lang hygiene (existing threads; unchanged by this push):
## Emoji Updateblock + mojibake (┬º/§) after PHUD.pt_BRstill has twoevents.beforeChat.formatlines; first (bracketed) wins.npm run syncLangFileson the branch and push — do not hand-append more keys.Still open:
titles_server_form.jsongrid_dimensions: [2, 14]hard-caps 28 cells.Nit: title strings remain English in non-EN locales.
mergeable=truevs currentmain. Open res issues: 0 (no Fixes links). Human reviews still stale.225f5df337801551c0f1Re-review head
801551c0f1b1(was225f5df337ab). Looks like a force-push/rebase rewrite of the same tip series — tip still “stillOwned” key. Companion beh#722 still open — do not merge res alone.This push: no material content fix vs prior RC. UI wiring (
$flag_titles/titles@titles.main_panel), glyph sheet, and title keys are still the right shape.Still blocking — CI:
ci.ymlrun 166 failure on this head (CI / build-and-test). Model-preview #167 success is not the gate. SamesyncLangFiles --checkclass as225f5df.Still blocking — lang hygiene (unchanged by this rewrite):
## Emoji Updateblock + mojibake (┬º/§) after PHUD.pt_BRstill has twoevents.beforeChat.formatlines; first (bracketed) wins, so Portuguese chat won’t pick up the title-aware string.npm run syncLangFileson the branch and push — do not hand-append more keys.Still open:
titles_server_form.jsongrid_dimensions: [2, 14]hard-caps 28 cells.Nit: title strings remain English in non-EN locales;
en_USstill picks up unrelatedserverDrop/chunkUnloadDropkeys.mergeable=truevs currentmain. Open res issues: 0 (no Fixes links). Human reviews still stale.@ -11658,3 +11658,37 @@ commands.spawnrate.success=Nastavení výskytu aktualizováno.## PHUDphud.playerPing.label=Aktuální ping:## Emoji UpdateBlocker: trailing second
## Emoji Updatedump + mojibake (┬º). Same in de/es/ru/zh.npm run syncLangFiles— don’t append tails by hand.@ -3978,0 +3994,4 @@events.beforeChat.error.parseFailed=§cFalha ao analisar seus dados!events.beforeChat.error.tooFast=§cVocê está enviando mensagens muito rapidamente. Por favor, diminua a velocidade e tente novamente.events.beforeChat.error.zalgo=§cSua mensagem contém zalgo e não pode ser enviada!events.beforeChat.format=§r%s§r§7 %s:§r %sBlocker: second
events.beforeChat.format— the bracketed line above still wins. Also the trailing second## Emoji Update+§/┬ºmojibake will failsyncLangFiles --check. Runnpm run syncLangFilesand push; don’t hand-append.@ -0,0 +39,4 @@"offset": [2, 0],"anchor_from": "top_left","anchor_to": "top_left","grid_dimensions": [2, 14],Still open:
grid_dimensions: [2, 14]hard-caps 28 cells. Catalog is ~25 today so it fits, but anything past 28 silently clips. Prefer binding rows from collection length, or document the cap with BEH.801551c0f112734a7962Re-review head
12734a796237(was801551c0f1b1). Force-push/rebase onto maine906936b(post findable-blocks). Companion beh#722 still open — do not merge res alone.This push: tip still “stillOwned” key series, but branch is now rebased cleanly onto current
main.mergeable=true.Cleared — lang hygiene: all 7 locales now match
en_USkey order (11571 keys), singleevents.beforeChat.format, single## Emoji Update/## Titles, no mojibake / duplicate-format tails. Prior syncLangFiles-class blockers from older heads look fixed on this tip. UnrelatedserverDrop/chunkUnloadDropdrift is no longer part of the Titles append.Still blocking — companion: keep res behind beh#722.
Still blocking — CI:
ci.ymlrun 179 failure on this head (Validate format versions; lang-sync + tests skipped). Model-preview #180 success is not the gate. Same step is red onmainitself (run 176 after #4 merge) — PR does not touchmodels//entity// other format-version scan dirs, so this looks inherited from base, not introduced here. Still: do not claim merge-ready while the gate is red.Still open:
titles_server_form.jsongrid_dimensions: [2, 14]hard-caps 28 cells (prior threads).Nit: title strings remain English in non-EN locales.
UI wiring (
$flag_titles/titles@titles.main_panel), glyph sheet, and title keys remain the right shape. Open res issues: 0 (no Fixes links). Human reviews still stale.@ -0,0 +39,4 @@"offset": [2, 0],"anchor_from": "top_left","anchor_to": "top_left","grid_dimensions": [2, 14],Still open from prior reviews:
grid_dimensions: [2, 14]hard-caps 28 cells. Catalog fits today (~25), but anything past 28 silently clips. Prefer binding rows from collection length, or document the cap with BEH.Re-review head
fbee22adfc4b(was12734a796237). Tip:fix: raise titles grid cap to 40 cells. Companion beh#722 still open — do not merge res alone.This push:
titles_server_form.jsongrid_dimensions[2, 14]→[2, 20](28 → 40 cells) and scroll content height182→260. Clears the prior hard-cap finding for the current ~25-title catalog with headroom. Still a fixed cap (not collection-length binding); fine for now — document or raise again if the catalog grows past 40.Still blocking — companion: keep res behind beh#722.
Still blocking — CI:
ci.ymlrun 181 failure on this head (model-preview #182 success is not the gate). Same class as prior tip /mainitself (run 176 after #4 merge) — PR does not touch format-version scan dirs, so inherited from base. Do not claim merge-ready while the gate is red.Nit: title strings remain English in non-EN locales.
UI wiring / glyph sheet / lang hygiene from prior tip unchanged and still look right.
mergeable=true. Open res issues: 0 (no Fixes links). Human reviews still stale.@ -0,0 +39,4 @@"offset": [2, 0],"anchor_from": "top_left","anchor_to": "top_left","grid_dimensions": [2, 20],Cleared prior 28-cell hard-cap note:
[2, 20]= 40 cells + taller scroll (260). Good for ~25 titles today. Still a fixed grid — bump again or bind to collection length if the catalog outgrows 40.@ -429,6 +429,9 @@"pokeb:yago_berry_plant": {"sound": "grass"},"pokeb:findable_block": {??? why here
@ -0,0 +1,250 @@{-_-
fbee22adfc0b88af267f997437ac56caa3d77719Re-review head
7758c17bead8(wasfbee22adfc4b/ prior tip before main merge). Tip:Merge branch 'main' into feature/title-update(brings in222b71bfv2.22.5 +5a2ff211format-version / Chrome runner fix). Companion beh#722 still open — do not merge res alone.This push: merge-from-main only. Title scope unchanged vs prior tip — same UI wiring (
$flag_titles/titles@titles.main_panel), glyph sheet, lang Titles block,grid_dimensions: [2, 20](40 cells). No new title-feature delta to re-litigate.Cleared — CI format-version gate:
ci.ymlrun 321 success on this head (inherited main failure from older tips is gone after5a2ff211). Model-preview run 322 was still running at review time and is not the merge gate.Still blocking — companion: keep res behind beh#722.
Still clear (no new threads): lang hygiene remains clean (single Titles append, single
events.beforeChat.format, no mojibake / duplicate-format tails). Grid cap finding stays cleared at 40 cells.Nit: title strings remain English in non-EN locales.
mergeable=truevs currentmain(5a2ff211). Open res issues: 0 (no Fixes links). Human reviews still stale on older SHAs. Not merge-ready until companion lands.Re-review head
7758c17bead8(wasfbee22adfc4b). Tip: mergemain(5a2ff211format-version fix) + priorcommands.titles.*/worldchampion/noFreeSlotcommits. Companion beh#722 still open — do not merge res alone.This push: merges current
mainontofeature/title-update. Material vs last bot tip also includes (already on branch before this merge):commands.tags.*→commands.titles.*,world_champion.png→worldchampion.png,forms.titles.error.noFreeSlot. Aligns with beh#722langKeys+ title idworldchampion.Cleared — CI:
ci.ymlrun 321 success on this head (CI / build-and-test). Prior format-version gate inherited frommainis green after5a2ff211. Model-preview #322 still running — not the gate.Cleared (unchanged): lang hygiene (all 7 locales key-order match
en_US, 11630 keys, singleevents.beforeChat.format, no mojibake / leftovercommands.tags.*); grid[2, 20]/ height 260; textures cover all 25 beh title ids.Still blocking — companion: keep res behind beh#722.
Nit: title strings remain English in non-EN locales.
UI wiring (
$flag_titles/titles@titles.main_panel), glyph sheet, and title keys remain the right shape.mergeable=true. Open res issues: 0 (no Fixes links). Human reviews still stale.Re-review head
b7d06fdf66a7(was7758c17bead8). Tip:Point model preview at the Forgejo copy of the action.Companion beh#722 still open — do not merge res alone.This push:
.github/workflows/model-preview.ymlonly —uses:smell-of-curry/mc-model-preview@latest→https://git.pokebedrock.com/pokebedrock/mc-model-preview@b10a8ffcf825203aa537c56ce48531249bf1ca6e(Forgejo copy, SHA-pinned). Correct for self-hosted Actions;@lateston the old GitHub path was fragile here. Verifiedpokebedrock/mc-model-preview+ commitb10a8ffcexist. No title-UI / lang / texture delta.Still blocking — companion: keep res behind beh#722.
CI:
ci.yml+model-preview.ymlboth pending on this head at review time (not settled yet). Prior tip7758c17bhadci.ymlgreen after main5a2ff211; this one-lineuses:swap should not regress build-and-test — confirm green before merge. Model-preview is not the merge gate.Still clear (no new threads): lang hygiene,
grid_dimensions: [2, 20]/ height 260, UI wiring ($flag_titles/titles@titles.main_panel), glyph sheet / title keys.Nit: title strings remain English in non-EN locales.
mergeable=truevs currentmain. Open res issues: 0 (no Fixes links). Human reviews still stale on older SHAs. Not merge-ready until companion lands.Re-review head
b7d06fdf66a7(was7758c17bead8). Tip:Point model preview at the Forgejo copy of the action.Companion beh#722 still open — do not merge res alone.This push: only
.github/workflows/model-preview.yml(smell-of-curry/mc-model-preview@latest→ Forgejopokebedrock/mc-model-preview@b10a8ffc…). Blob matches currentmain— no title-feature delta vs prior tip. UI wiring ($flag_titles/titles@titles.main_panel), glyph sheet,commands.titles.*/worldchampion.png, grid[2, 20]/ height 260 unchanged.Still blocking — companion: keep res behind beh#722.
CI:
ci.ymlrun 353 + model-preview run 354 still pending (waiting) on this head. Prior tip had build-and-test green after5a2ff211; not calling merge-ready while the new gate is queued.Cleared (unchanged): lang hygiene (Titles append, single
events.beforeChat.format, no mojibake / leftovercommands.tags.*); grid cap at 40 cells.Nits: PR body empty; title uses
feat;(semicolon). Title strings still English in non-EN locales.mergeable=truevsmain(9a5af785). Open res issues: 0 (no Fixes links). Human reviews still stale on older SHAs.Re-review head
6940f6d0eb58(wasb7d06fdf66a7). Tip:revert: restore original titles json ui and gui texture. Companion beh#722 still open (head12b5ec76) — do not merge res alone.This push:
ui/titles_server_form.jsonback togrid_dimensions: [2, 14]/ scroll height182(revertsb165fd43), andtextures/ui/titles/titles_gui.pngswapped back to the original asset (same 206×186, different pixels). Reads as an intentional author revert; no lang / glyph / title-texture delta.Non-blocking — grid cap is back to 28 cells. beh#722
TITLEShas 25 ids today and the form only lists owned titles, so it fits with 3 to spare. A 29th title will silently clip. Fine to ship; whoever adds titles past 28 must bump this (inline).Still blocking — companion: keep res behind beh#722.
CI:
CI / build-and-testrun 368 success on this head. Model-preview run 369 pending, not the gate.Cleared (unchanged): lang hygiene, UI wiring (
$flag_titles/titles@titles.main_panel), glyph sheet,commands.titles.*/worldchampion.png.Nits: PR body empty; title uses
feat;(semicolon); title strings still English in non-EN locales.mergeable=truevsmain(9a5af785). Open res issues: 0 (no Fixes links).@ -0,0 +39,4 @@"offset": [2, 0],"anchor_from": "top_left","anchor_to": "top_left","grid_dimensions": [2, 14],Back to a 28-cell cap (
2 × 14). 25 titles in beh#722 today, so it fits — but title #29 clips silently with no error. Not blocking; leave a note for whoever extendsTITLES, or bump rows +sizeheight together when that happens.Re-review head
6940f6d0eb58(wasb7d06fdf66a7). Tip:revert: restore original titles json ui and gui texture. Companion beh#722 still open (head12b5ec762f) — do not merge res alone.This push:
ui/titles_server_form.jsonback togrid_dimensions: [2, 14]/ scroll height182(40 → 28 cells), plustextures/ui/titles/titles_gui.pngswapped back to the original art. Reverts thefbee22adcap raise.Re-opened (inline): 28-cell hard cap again. Catalog today is 25 title textures, so it fits with 3 slots of headroom, but title #29+ silently clips. If the revert is intentional (layout/art reasons), fine — say so in the PR and coordinate the cap with BEH so nobody adds titles past 28 without bumping this.
CI:
CI / build-and-testsuccess and Model Preview success on this head.Still clear (unchanged): lang hygiene, UI wiring (
$flag_titles/titles@titles.main_panel), glyph sheet,commands.titles.*/worldchampion.png.Still blocking — companion: keep res behind beh#722.
Nits: PR body empty; title uses
feat;(semicolon). Title strings still English in non-EN locales.mergeable=truevsmain(9a5af785). Open res issues: 0 (no Fixes links).@ -0,0 +39,4 @@"offset": [2, 0],"anchor_from": "top_left","anchor_to": "top_left","grid_dimensions": [2, 14],Back to
[2, 14]= 28 cells (scroll height 182). Fits the current 25 titles, but anything past 28 silently clips. If this revert is intentional, document the cap or bind rows from collection length.Re-review head
598e9e22(was6940f6d0). Tip:fix titles menu: hide empty grid cells.This push:
item_buttoninui/titles_server_form.jsongets a view binding(not (#form_button_text = ''))→#visible. Looks right: every real title button from beh#722'sTitlesForm.mainhas non-empty text (§f<name>\n§7<status>), so only the padding cells disappear. No problems with the change itself.CI:
CI / build-and-testand Model Preview are still pending on this head.Still blocking — companion: beh#722 is still open (head
12b5ec762f). Don't merge res on its own.The earlier open threads are unchanged and I'm not repeating them here.
mergeable=truevsmain(7e6ccf54). Open res issues: 0, so no Fixes links.Re-review head
598e9e221181(was6940f6d0eb58). Tip:fix titles menu: hide empty grid cells. Companion beh#722 still open (head70a29448) — do not merge res alone.This push: one view binding on
titles.item_buttoninui/titles_server_form.json:#visible=(not (#form_button_text = '')). Fix is correct. beh#722TitlesForm.mainalways sends§f<name>\n§7<status>text per owned title, so real buttons never match''; only the unfilled cells of the fixed[2, 14]grid get hidden, which also kills their stray hover/focus border.banner_imagealready hid the empty texture, so this was the missing half.Nit (inline): every other view binding in this file carries
"binding_name": "#null". Add it here for consistency.Still open (non-blocking, prior thread): grid is still a 28-cell hard cap with scroll height
182. Now that empty cells hide, raisinggrid_dimensionslater costs nothing visually, but the fixed height would still clip — bump both together when the catalog passes 28.Still blocking — companion: keep res behind beh#722.
CI:
CI / build-and-testrun 386 + model-preview run 387 pending on this head. Not calling merge-ready until the gate settles green.Unchanged / still clear: lang hygiene, UI wiring (
$flag_titles/titles@titles.main_panel), glyph sheet,commands.titles.*/worldchampion.png.Nits: PR body empty; title uses
feat;(semicolon); title strings still English in non-EN locales.mergeable=truevsmain(7e6ccf54). Open res issues: 0 (no Fixes links).@ -0,0 +81,4 @@"binding_collection_name": "form_buttons"},{"binding_type": "view",Nit: match the rest of this file and add
"binding_name": "#null"to this view binding (seebanner_imageandhover_control). Logic is fine — real title buttons always have text from beh#722, so only filler cells hide.Follow-up on RC 3099/3100 (head
598e9e22hasn't changed). This isn't a new review. The earlier findings still stand.New conflict: against res main
b4a8343a(v3.1.1), this branch now conflicts in all 7texts/*.langfiles. It was mergeable when it was reviewed. The cause is an end-of-file append clash: main appended keys aftermessage.rewards.grantError, and this branch appends its## Titlesblock there too. I checked a union resolution (keep both blocks): no duplicate keys in en_US or pt_BR. Keep the same block order in every lang so the lang-sync check passes. The split-pack build (#20) has a catch-all, so the new glyph/UI files need no pack mapping.This still has to merge together with BEH #722, whose data pin (3183 / 13084) needs to land first.
598e9e2211eed96697f8Re-review head
eed96697(was598e9e22). This push squashes the branch into one commit,feat: title system ui, glyphs and lang, and rebases it ontomainb4a8343a(v3.1.1).mergeable=true.This push: no content change. I checked every non-image file in the PR (7 lang files,
ui/_ui_defs.json,ui/server_form.json,ui/titles_server_form.json) against the old head and they're the same. The 27textures/ui/titles/*.pngandfont/glyph_E3.pngblobs are the same too. The PR diff is now just the title system, so the scope is clean.Still open from before (not repeating): the
binding_name: "#null"nit on theitem_buttonview binding inui/titles_server_form.jsonwasn't addressed, and the earlier threads still stand.Still blocking, companion: beh#722 is still open (head
5f5ed83c, changes requested). The chat format change here (events.beforeChat.formatdrops the[...]rank brackets) only looks right with #722's title prefix, so don't merge res on its own. The rank titles in data#22 (artist, developer, game designer, assistant manager, project manager) already have matching textures here.CI:
CI / build-and-testpassed on this head. Model Preview is still pending, so this isn't merge-ready yet.Open res issues: 0, so there are no Fixes links.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.