Add Missing Halloween Skin #26

## Minecraft Model Preview (01fb58b) ### Model Changes | Entity | Before | After | |--------|--------|-------| | _No renderable model changes detected_ | | |

bot requested changes

2026-10-17 22:24:26 +00:00

bot left a comment

Changes requested at 01fb58bd. The Leafeon skin itself looks right (textures, 3D rc, substitute rc, customizations entry), but a few things outside that scope will break or confuse things, and CI / build-and-test is red on this head while main is green.

manifest.json header uuid changed. That changes the pack's identity; it looks like a local-dev uuid leaked in. Please revert it.
Eevee shiny Halloween texture paths now point at shiny_male_eevee_halloween.png / shiny_female_eevee_halloween.png, but the files on this branch are still male_shiny_eevee_halloween.png / female_shiny_eevee_halloween.png. Shiny Halloween Eevee would render missing-texture. Either revert the path change or rename the files too.
Unrelated changes ride along: new animations/playeranimation.animation.json (659 lines of dynamax player animations), deleted subpacks/3d/animation_controllers/pokemon/eevee.json, and the jolteon controller/entity edits. If those are intentional, split them into their own PR with a note; for a hotfix, keep it to Leafeon.
scripts/data/customizations.ts was reformatted wholesale (trailing commas stripped, ~357 lines churned) by a formatter config that doesn't match the repo. Please revert to the repo's formatting so the only change is the leafeon entry.

Re-run CI after the cleanup; if it's still red, paste the failing step. Twins: beh #783 / data #21 should land in data, beh, res order as noted there.

Changes requested at 01fb58bd. The Leafeon skin itself looks right (textures, 3D rc, substitute rc, customizations entry), but a few things outside that scope will break or confuse things, and `CI / build-and-test` is red on this head while main is green. 1. `manifest.json` header uuid changed. That changes the pack's identity; it looks like a local-dev uuid leaked in. Please revert it. 2. Eevee shiny Halloween texture paths now point at `shiny_male_eevee_halloween.png` / `shiny_female_eevee_halloween.png`, but the files on this branch are still `male_shiny_eevee_halloween.png` / `female_shiny_eevee_halloween.png`. Shiny Halloween Eevee would render missing-texture. Either revert the path change or rename the files too. 3. Unrelated changes ride along: new `animations/playeranimation.animation.json` (659 lines of dynamax player animations), deleted `subpacks/3d/animation_controllers/pokemon/eevee.json`, and the jolteon controller/entity edits. If those are intentional, split them into their own PR with a note; for a hotfix, keep it to Leafeon. 4. `scripts/data/customizations.ts` was reformatted wholesale (trailing commas stripped, ~357 lines churned) by a formatter config that doesn't match the repo. Please revert to the repo's formatting so the only change is the `leafeon` entry. Re-run CI after the cleanup; if it's still red, paste the failing step. Twins: beh #783 / data #21 should land in data, beh, res order as noted there.

animations/playeranimation.animation.json

					
				@ -0,0 +1,659 @@

				{

Unrelated to the Leafeon skin (dynamax player animations). Split out or drop from this hotfix.

manifest.json Outdated

					
				@ -5,3 +5,3 @@

				    "description": "pack.description",

				    "min_engine_version": [1, 26, 0],

				    "uuid": "358dc189-8d9e-4fdb-b4e1-f8e0fb855f9a",

				    "uuid": "bd48cc55-7a4a-408d-a044-ae29d4ccdbc1",

Header uuid changed; this changes the pack identity. Revert to 358dc189-8d9e-4fdb-b4e1-f8e0fb855f9a.

Header uuid changed; this changes the pack identity. Revert to `358dc189-8d9e-4fdb-b4e1-f8e0fb855f9a`.

Header UUID changed (358dc189-… → bd48cc55-…). That makes this a different pack to clients and servers; anything referencing the old UUID breaks. Revert.

Header UUID changed (`358dc189-…` → `bd48cc55-…`). That makes this a different pack to clients and servers; anything referencing the old UUID breaks. Revert.

scripts/data/customizations.ts

					
				@ -5,3 +5,3 @@

				  ParticleEffectId,

				  PokemonSkinOptionObject,

				  MaterialId,

				  MaterialId

Formatter stripped every trailing comma in the file. Revert the reformat so only the leafeon entry changes.

Formatter stripped every trailing comma in the file. Revert the reformat so only the `leafeon` entry changes.

subpacks/3d/entity/pokemon/eevee.entity.json

					
				@ -15,3 +15,3 @@

								"shiny_female_default": "textures/entity/pokemon/eevee/female_shiny_eevee.png",

								"male_halloween": "textures/entity/pokemon/eevee/male_eevee_halloween.png",

								"shiny_male_halloween": "textures/entity/pokemon/eevee/male_shiny_eevee_halloween.png",

								"shiny_male_halloween": "textures/entity/pokemon/eevee/shiny_male_eevee_halloween.png",

No shiny_male_eevee_halloween.png exists on this branch; the file is male_shiny_eevee_halloween.png. This breaks shiny Halloween Eevee.

No `shiny_male_eevee_halloween.png` exists on this branch; the file is `male_shiny_eevee_halloween.png`. This breaks shiny Halloween Eevee.

This file doesn't exist. The repo has male_shiny_eevee_halloween.png, so this breaks shiny Halloween Eevee. Revert the rename.

This file doesn't exist. The repo has `male_shiny_eevee_halloween.png`, so this breaks shiny Halloween Eevee. Revert the rename.

subpacks/3d/entity/pokemon/eevee.entity.json

					
				@ -18,2 +17,3 @@

								"shiny_male_halloween": "textures/entity/pokemon/eevee/shiny_male_eevee_halloween.png",

								"female_halloween": "textures/entity/pokemon/eevee/female_eevee_halloween.png",

								"shiny_female_halloween": "textures/entity/pokemon/eevee/female_shiny_eevee_halloween.png"

								"shiny_female_halloween": "textures/entity/pokemon/eevee/shiny_female_eevee_halloween.png"

Same here: the file is female_shiny_eevee_halloween.png.

Same here: the file is `female_shiny_eevee_halloween.png`.

Same issue: the file on disk is female_shiny_eevee_halloween.png.

Same issue: the file on disk is `female_shiny_eevee_halloween.png`.

textures/item_texture.json

					
				@ -8048,2 +8077,4 @@

				    "sylveon_halloween": {

				      "textures": "textures/sprites/default/sylveon_halloween.png"

				    },

				    "leafeon_halloween": {

Duplicate leafeon_halloween key; it's also added at line 8056. Drop this one.

Duplicate `leafeon_halloween` key; it's also added at line 8056. Drop this one.

bot commented

2026-10-17 22:38:43 +00:00

Follow-up to 3215, on the same head 01fb58bd. These are new findings only.

Why CI is red: validate:formatVersions fails with animations/playeranimation.animation.json: format_version "1.8.0" is below required "1.10.0". I reproduced this locally on a clean npm ci, and syncLangFiles --check passes. Dropping that stray file (point 3 in 3215) should clear the job.
Where the manifest UUID came from: bd48cc55-… is FULL_HEADER_UUID in scripts/data/splitPacks.ts, the UUID that build.ts writes into the full/server build. So this manifest was copied from local build output. It's not a random dev UUID. The release build also hard-fails on it: build.ts:345 throws manifest header UUID … != PUBLIC_HEADER_UUID. Revert it to 358dc189-….
More churn: textures/item_texture.json also reformats about 13 single-entry arrays (calcium … backpack) into multi-line ones. That's the same build/formatter drift. Please revert it along with the duplicate leafeon_halloween key.
Jolteon, if it stays: halloween_blink and halloween_faint get mapped, but the controller never plays them, and default_blink now also runs for skin 1. If that's intended, say so in the split PR.

beh#783 needs this PR, and its merge order is in review 3217: showdown#17 → publish → data#21 → this → beh#783.

Follow-up to 3215, on the same head `01fb58bd`. These are new findings only. - **Why CI is red:** `validate:formatVersions` fails with `animations/playeranimation.animation.json: format_version "1.8.0" is below required "1.10.0"`. I reproduced this locally on a clean `npm ci`, and `syncLangFiles --check` passes. Dropping that stray file (point 3 in 3215) should clear the job. - **Where the manifest UUID came from:** `bd48cc55-…` is `FULL_HEADER_UUID` in `scripts/data/splitPacks.ts`, the UUID that `build.ts` writes into the full/server build. So this manifest was copied from local build output. It's not a random dev UUID. The release build also hard-fails on it: `build.ts:345` throws `manifest header UUID … != PUBLIC_HEADER_UUID`. Revert it to `358dc189-…`. - **More churn:** `textures/item_texture.json` also reformats about 13 single-entry arrays (`calcium` … `backpack`) into multi-line ones. That's the same build/formatter drift. Please revert it along with the duplicate `leafeon_halloween` key. - **Jolteon, if it stays:** `halloween_blink` and `halloween_faint` get mapped, but the controller never plays them, and `default_blink` now also runs for skin 1. If that's intended, say so in the split PR. beh#783 needs this PR, and its merge order is in review 3217: showdown#17 → publish → data#21 → this → beh#783.

smell-of-curry added 1 commit

2026-10-18 16:16:38 +00:00

Keep the public pack UUID and raise the player animation format version.

CI / build-and-test (20.x) (pull_request) Successful in 41s

Details

Model Preview / model-preview (pull_request) Successful in 1m37s

Details

882482d601

Co-authored-by: Cursor <cursoragent@cursor.com>

smell-of-curry merged commit d42f7fe6a9 into main

2026-10-18 16:17:05 +00:00

smell-of-curry referenced this pull request from a commit

2026-10-18 16:17:06 +00:00

Add Missing Halloween Skin (#26)

forgejo-actions commented

2026-10-18 16:18:11 +00:00

Minecraft Model Preview (`882482d`)

Model Changes

Entity	Before	After
No renderable model changes detected

## Minecraft Model Preview (882482d) ### Model Changes | Entity | Before | After | |--------|--------|-------| | _No renderable model changes detected_ | | |

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

pokebedrock/pokebedrock-res!26

				`@ -0,0 +1,659 @@`
				`{`

Rows
Columns