docs: align PR template testing checklist with npm run ci #39

Closed
opened 2026-03-13 19:03:17 +00:00 by pokebedrock-bot · 0 comments
pokebedrock-bot commented 2026-03-13 19:03:17 +00:00 (Migrated from github.com)

Summary

The pull request template still asks contributors to manually check off npm run lint, npm run lint:links, and npm run build:search.

Evidence

  • .github/PULL_REQUEST_TEMPLATE.md currently lists:
    • npm run lint
    • npm run lint:links
    • npm run build:search (when touching navigation or metadata)
  • The repo-standard contributor guidance elsewhere has already moved to npm run ci as the canonical pre-push / pre-PR validation command because it wraps linting, link checks, search generation, and generated-file drift checks.

Impact

Contributors can follow the PR template and still miss the actual full repo gate, especially the generated-artifact sync check that npm run ci enforces.

Acceptance criteria

  • The PR template tells contributors to run npm run ci as the standard verification command.
  • Any extra note about search/index-related changes is framed as optional context, not a replacement for npm run ci.
  • The resulting wording matches the repo's current contributor guidance and CI expectations.
## Summary The pull request template still asks contributors to manually check off `npm run lint`, `npm run lint:links`, and `npm run build:search`. ## Evidence - `.github/PULL_REQUEST_TEMPLATE.md` currently lists: - `npm run lint` - `npm run lint:links` - `npm run build:search` (when touching navigation or metadata) - The repo-standard contributor guidance elsewhere has already moved to `npm run ci` as the canonical pre-push / pre-PR validation command because it wraps linting, link checks, search generation, and generated-file drift checks. ## Impact Contributors can follow the PR template and still miss the actual full repo gate, especially the generated-artifact sync check that `npm run ci` enforces. ## Acceptance criteria - The PR template tells contributors to run `npm run ci` as the standard verification command. - Any extra note about search/index-related changes is framed as optional context, not a replacement for `npm run ci`. - The resulting wording matches the repo's current contributor guidance and CI expectations.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pokebedrock/wiki#39
No description provided.